Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose formatData and data objects #46

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

flashdesignory
Copy link
Collaborator

@flashdesignory flashdesignory commented Jun 5, 2024

This pr exposes the formatData utils function in the build files as well as data objects for each wrapper.

@kara

@flashdesignory flashdesignory changed the title expose formatData expose formatData and data objects Jun 5, 2024
@flashdesignory flashdesignory requested a review from kara June 5, 2024 22:08
Copy link
Contributor

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️ ! Seems like json are even correctly typed in the generated d.ts files !

@huang-julien
Copy link
Contributor

fix #42

@flashdesignory
Copy link
Collaborator Author

update: exposing all utils functions that are exported now

Copy link
Collaborator

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flashdesignory flashdesignory merged commit 2dcf998 into GoogleChromeLabs:main Jun 5, 2024
2 checks passed
@flashdesignory flashdesignory deleted the chore/exports branch June 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants