add missing options types #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huang-julien - some missing types, now we export all param types needed as input for tpc |
src/types/type-declarations.ts
Outdated
| @@ -111,3 +111,21 @@ export interface GoogleTagManagerApi { | |||
| dataLayer: Record<string, any>[]; | |||
| google_tag_manager: GoogleTagManager; | |||
| } | |||
|
|
|||
| /* Google Maps Embed */ | |||
| export interface GoogleMapsEmbedOptions { | |||
There was a problem hiding this comment.
Suggested change
| export interface GoogleMapsEmbedOptions { | |
| export interface GoogleMapsEmbedQueries { |
There was a problem hiding this comment.
I think this should be suffixed with Queries instead of Options as width and height are missing.
GoogleMapsEmbedOptions should probably be something like
type GoogleMapsEmbedOptions = GoogleMapsEmbedQueries & GoogleMapsEmbedAttributes
There was a problem hiding this comment.
ah I see - yeah, makes sense to differentiate between attributes and params... how about:
GoogleMapsEmbedParams ? in that way it matches "attributes" and "params" keys in the json files: https://github.com/GoogleChromeLabs/third-party-capital/blob/main/src/third-parties/google-maps-embed/data.json#L12
Co-authored-by: Julien Huang <[email protected]>
housseindjirdeh
approved these changes
Jun 24, 2024
huang-julien
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional types export for missing params
@kara