fix: assign dataLayer from gtag to the datalayers object #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huang-julien
commented
Jul 22, 2024
| "strategy": "worker", | ||
| "location": "head", | ||
| "action": "append", | ||
| "key": "gtag" | ||
| }, | ||
| { | ||
| "code": "window.dataLayers=window.dataLayers||{};window.dataLayers['{{dataLayerName}}']=window.dataLayers['{{dataLayerName}}']||[];window.gtag=function gtag(){window.dataLayers['{{dataLayerName}}'].push(arguments);};window.gtag('js',new Date());window.gtag('config','{{id}}')", | ||
| "code": "window.dataLayers=window.dataLayers||{};window.dataLayers['{{dataLayerName}}']=window.dataLayers['{{dataLayerName}}']||window.{{dataLayerName}}||[];window.gtag=function gtag(){window.dataLayers['{{dataLayerName}}'].push(arguments);};window.gtag('js',new Date());window.gtag('config','{{id}}')", | ||
| "params": ["id", "dataLayerName"], |
There was a problem hiding this comment.
dataLayerName should probably be renamed to l to keep the naming consistent ?
There was a problem hiding this comment.
also because everyone is probably expecting to use one name for datalayer. l has the JSDoc added anyway so users won't have to look for the meaning of l
|
probably needs to wait #54 to be merged first |
|
closing since we're going to rollback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR fix #55 . The issue is that we were creating our own dataLayers object to store the arrays from gtm. One thing was missing which is the
lquery parameter in the external script : https://developers.google.com/tag-platform/tag-manager/datalayer