Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Parameters<Gtag> for datalayer #60

Merged
merged 2 commits into from
Jul 28, 2024
Merged

fix: use Parameters<Gtag> for datalayer #60

merged 2 commits into from
Jul 28, 2024

Conversation

huang-julien
Copy link
Contributor

When typing a function as GTag, we cannot push the args into DataLayer due to its type.

@huang-julien
Copy link
Contributor Author

cc @flashdesignory

flashdesignory
flashdesignory approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flashdesignory flashdesignory merged commit e0afbd2 into GoogleChromeLabs:main Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flashdesignory flashdesignory flashdesignory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huang-julien @flashdesignory