move json files to root #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @flashdesignory! I opened #65 to update the PHP code accordingly. It would be great if you could merge that as soon as you've merged this one, or alternatively feel free to merge it into this PR so we can handle the changes altogether. |
felixarntz
approved these changes
Aug 22, 2024
housseindjirdeh
approved these changes
Aug 28, 2024
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| import data from './data.json'; | |||
| import data from '../../../data/google-tag-manager.json'; | |||
There was a problem hiding this comment.
Should we consider including absolute imports via alias (e.g. @/data/...)? Might be overkill and something we can worry about in a future PR
| import GoogleTagManagerData from './google-tag-manager/data.json'; | ||
| import GoogleMapsEmbedData from './google-maps-embed/data.json'; | ||
| import GoogleYoutubeEmbedData from './youtube-embed/data.json'; | ||
| import GooglaAnalyticsData from '../../data/google-analytics.json'; |
There was a problem hiding this comment.
Seems like a typo from a previous PR squeezed through:
Suggested change
| import GooglaAnalyticsData from '../../data/google-analytics.json'; | |
| import GoogleAnalyticsData from '../../data/google-analytics.json'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder organization: this just moves all the json files into a dedicated
datafolder in the root of the repo.Nothing else changed.
@felixarntz for awareness and feedback. Hopefully that'll make it easier for the php integration.
@kara