Bring PHP functionality in line with recent JS changes and add integration tests for third parties #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date GitHub workflows.
felixarntz
requested review from
adamsilverstein,
flashdesignory and
housseindjirdeh
housseindjirdeh
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Cheers thanks for doing this 😍
Will wait for @adamsilverstein to approve before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66.
This PR makes several enhancements:
optionalParamsfor scripts, as was recently introduced in the JS codebase (see Add optional parameters in gtm and ga json #58).It may be helpful for the review process to review the individual commits as part of this PR, rather than all changes at once.
Effectively, this PR does everything needed to bring it up to date with the JS codebase, and it includes test coverage to make sure in the future it doesn't get out of date without being noticed.