docs: improve analytics types #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huang-julien
changed the title
felixarntz
reviewed
Sep 14, 2024
data/google-analytics.json
Outdated
| @@ -19,8 +19,7 @@ | |||
| "params": ["id"], | |||
| "optionalParams": { | |||
| "l": "dataLayer", | |||
| "consentType": "default", | |||
| "consentValues": null | |||
There was a problem hiding this comment.
See #72 (comment) - while technically it doesn't matter, I think there is value in keeping parameters explicit in the schema, even if their default is null or undefined.
There was a problem hiding this comment.
I understand now, let's add it back :)
huang-julien
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey 👋 here's some slights improvement for GA
We can remove the JS docs for the default value of consentValues. We can also remove consentValues from the optionalParams since undefined should be falsy by default
cc @felixarntz