Move gemini rating logic to server #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
devnook
commented
Jul 8, 2024
devnook
commented
- Adds a Cloud function in /functions dir that serves Gemini powered ratings.
- Removes gemini logic from the frontend
tomayac
approved these changes
Aug 23, 2024
| functions.http('product-reviews-gemini-get-rating', async (req, res) => { | ||
| res.set('Access-Control-Allow-Origin', '*'); | ||
| if (req.method === 'OPTIONS') { | ||
| console.log('is OPTIONS') |
There was a problem hiding this comment.
Suggested change
| console.log('is OPTIONS') |
| return res.status(204).send(''); | ||
| } | ||
|
|
||
| if (!req.body.review) { |
There was a problem hiding this comment.
Drive by comment: would it make sense to implement a few best practices here around making sure that calls only come from your own website? (e.g. checking referrer...). I know that this can easily be spoofed, but might be a good indicator for people looking at this that they should think about how to secure their API endpoints.
This might also be complete overkill here...
|
@devnook this PR has conflicts and can't be merge. Is it still going to be updated or should it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.