Update to latest library version from Packagist #3
Conversation
|
@adamsilverstein Once this is merged, I think the codebase is ready for a 1.0 release, then only pending a first Packagist release of Third Party Capital. I believe the idea is to release its version 3.0 soon, and once that is out we can rely on it here and ship |
| ) | ||
| ); | ||
|
|
||
| add_action( 'wp_loaded', array( $gtm, 'add_hooks' ) ); |
There was a problem hiding this comment.
reviewing the entire doc I noticed they all include a hook line like add_action( 'wp_loaded', array( $yte, 'add_hooks' ) ); except "Google Maps Embed". Should it also include the hook line? If not maybe a single line explaining why these are included in the other examples but not this one.
There was a problem hiding this comment.
@adamsilverstein Great point! I clarified this in 7c43462.
The reason Google Maps Embed doesn't need to add hooks is that there are no assets (scripts or stylesheets) needed for it. You could technically still include the same hook callback, but it just wouldn't do anything. So if you know that already, you can omit it, that's why the snippet here does that.
Now that Third Party Capital is on Packagist, this PR updates to its latest version coming from there.
It also updates the readme file, adding an example for the recently added Google Tag Manager third party, and it adds a few other minor readme enhancements like linking to the JSON schema source files for additional information on the supported parameters. This is probably fine at this point, as from the JSON they're easy enough to understand for developers, and it means that we don't have to manually maintain documentation for all the fields in here.