Make {Read,Write}Options-parsing methods public #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
clairemcginty
commented
Jan 10, 2025
| @@ -653,7 +653,7 @@ private static GoogleCloudStorageReadOptions getReadChannelOptions(Configuration | |||
| .build(); | |||
| } | |||
|
|
|||
| private static AsyncWriteChannelOptions getWriteChannelOptions(Configuration config) { | |||
| public static AsyncWriteChannelOptions getWriteChannelOptions(Configuration config) { | |||
There was a problem hiding this comment.
though this method isn't strictly needed based on my Beam PR, I thought it made sense to make it public as well to have symmetry with the getReadChannelOptions method.
clairemcginty
force-pushed
the
patch-1
branch
from
187531d to
aa5ee8e
Compare
clairemcginty
force-pushed
the
patch-1
branch
from
aa5ee8e to
c1c7f86
Compare
|
hi, I just wanted to bump this PR! @arunkumarchacko, would you have time to take a look? thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I'm an Apache Beam user who recently contributed this PR to allow users to pass in custom StorageReadOptions to a Beam Pipeline. However, I don't have an easy way to construct these options from my
Configurationobjects. I'm proposing to make this method public in gcs-connector so I can easily transform aConfigurationinto aGoogleCloudStorageReadOptionsinstance.