feat: add support for custom certificate path #1805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
============================================
- Coverage 43.99% 43.99% -0.01%
- Complexity 3451 3453 +2
============================================
Files 830 830
Lines 49156 49167 +11
Branches 5153 5155 +2
============================================
+ Hits 21628 21630 +2
- Misses 25871 25879 +8
- Partials 1657 1658 +1
|
fbiville
force-pushed
the
neo4j/custom_cert
branch
from
1c5df43 to
d4af293
Compare
ali-ince
suggested changes
Sep 2, 2024
...rc/main/java/com/google/cloud/teleport/v2/neo4j/model/connection/CustomConnectionParams.java
Outdated
Show resolved
Hide resolved
v2/googlecloud-to-neo4j/src/main/resources/schemas/connection.v1.0.json
Outdated
Show resolved
Hide resolved
.../src/test/java/com/google/cloud/teleport/v2/neo4j/model/connection/ConnectionParamsTest.java
Show resolved
Hide resolved
fbiville
force-pushed
the
neo4j/custom_cert
branch
from
1242a4a to
19d596f
Compare
fbiville
force-pushed
the
neo4j/custom_cert
branch
from
19d596f to
c2869ba
Compare
This is an extra attribute that can now be added to the connection JSON information. Fixes GoogleCloudPlatform#1794
fbiville
force-pushed
the
neo4j/custom_cert
branch
from
c2869ba to
da5433c
Compare
|
No customer feedback, closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extra attribute that can now be added to the connection JSON information.
Fixes #1794