Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updating the default string to gson object for mongodb to bigquery da…" #1850

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Sep 9, 2024

Reverts #1796

This change introduced incompatible schema change that is affecting users of the template.

@Polber Polber requested a review from ahmedabu98 September 9, 2024 17:35
@Polber Polber self-assigned this Sep 9, 2024
@ahmedabu98
Copy link
Contributor

CC @wazi55

Fixes #1834

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.28%. Comparing base (587a0a8) to head (1ee837c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1850   +/-   ##
=========================================
  Coverage     43.28%   43.28%           
- Complexity     3518     3519    +1     
=========================================
  Files           832      832           
  Lines         48609    48609           
  Branches       5233     5233           
=========================================
+ Hits          21039    21040    +1     
  Misses        25877    25877           
+ Partials       1693     1692    -1     
Components Coverage Δ
spanner-templates 63.66% <ø> (+<0.01%) ⬆️
spanner-import-export 63.83% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 75.11% <ø> (ø)
spanner-live-reverse-replication 68.93% <ø> (ø)
spanner-bulk-migration 84.19% <ø> (ø)

see 1 file with indirect coverage changes

@Polber Polber merged commit 11d3722 into main Sep 10, 2024
17 checks passed
@Polber Polber deleted the revert-1796-zwang/mongo2bq1793 branch September 10, 2024 15:49
asthamohta pushed a commit to asthamohta/DataflowTemplates that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants