Skip to content

Commit

Permalink
Fixing issue with package notebook in jupyterhub image.
Browse files Browse the repository at this point in the history
 - Refactoring of code so it can build and install directly the authentication package
    instead of getting it from github.
 - Installing notebook as a separate dependency
 - Letting pip install the jupyterhub version according to the notebook package.
  • Loading branch information
german-grandas committed Aug 27, 2024
1 parent 5796d4b commit 2f39ba0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
9 changes: 9 additions & 0 deletions modules/jupyter/authentication/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM jupyterhub/k8s-hub:3.3.8

ADD ./authenticator/ ./authenticator

USER root
RUN chmod -R u+w ./authenticator

RUN pip3 install notebook
RUN pip3 install ./authenticator
4 changes: 2 additions & 2 deletions modules/jupyter/authentication/authenticator/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
long_description="long description here",
long_description_content_type="text/markdown",
url="https://github.com/chiayi/ai-on-gke/tree/main/ray-on-gke/user/jupyterhub/auth",
packages=['gcpiapjwtauthenticator'],
packages=setuptools.find_packages(),
license='Apache 2.0',
install_requires=[
"jupyterhub>=4.1.0",
"jupyterhub",
"tornado>=6.3.3",
'oauthenticator>=0.9.0',
'pyjwt>=2.7.0',
Expand Down
3 changes: 0 additions & 3 deletions modules/jupyter/authentication/docker_image/Dockerfile

This file was deleted.

0 comments on commit 2f39ba0

Please sign in to comment.