Merge pull request #32 from yiyinglovecoding/tpu

add tpu node location in template
GoogleCloudPlatform · Sep 8, 2023 · 9feabbd · 9feabbd
2 parents 8bef440 + 490cea7
commit 9feabbd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/ray-on-gke/platform/modules/gke_standard/main.tf b/ray-on-gke/platform/modules/gke_standard/main.tf
@@ -126,6 +126,7 @@ resource "google_container_node_pool" "tpu_pool" {
   provider           = google-beta
   name               = "tpu-pool"
   location           = var.region
+  node_locations     = ["us-central2-b"]
   cluster            = var.enable_autopilot == false && var.enable_tpu ? google_container_cluster.ml_cluster[0].name : null
   initial_node_count = var.num_nodes
   count              = var.enable_autopilot == false && var.enable_tpu ? 1 : 0

diff --git a/ray-on-gke/user/jupyterhub/jupyterhub.tf b/ray-on-gke/user/jupyterhub/jupyterhub.tf
@@ -27,12 +27,12 @@ provider "helm" {
 }
 
 resource "helm_release" "jupyterhub" {
-  name       = "jupyterhub"
-  repository = "https://jupyterhub.github.io/helm-chart"
-  chart      = "jupyterhub"
-  namespace  = var.namespace
+  name             = "jupyterhub"
+  repository       = "https://jupyterhub.github.io/helm-chart"
+  chart            = "jupyterhub"
+  namespace        = var.namespace
   create_namespace = var.create_namespace
-  cleanup_on_fail = "true"
+  cleanup_on_fail  = "true"
 
   values = [
     file("${path.module}/jupyter_config/config.yaml")

diff --git a/ray-on-gke/user/jupyterhub/variables.tf b/ray-on-gke/user/jupyterhub/variables.tf
@@ -19,7 +19,7 @@ variable "namespace" {
 }
 
 variable "create_namespace" {
-  type = bool
+  type        = bool
   description = "Enable creation of jupyterhub namespace if it does not exist"
-  default = false
+  default     = false
 }