fix: add todo

Change-Id: I3357e8f9dd16c7958dff0f0cf0f990fce980f474
GoogleCloudPlatform · Aug 14, 2024 · ac773b2 · ac773b2
1 parent 2bc8d56
commit ac773b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/applications/rag/main.tf b/applications/rag/main.tf
@@ -245,7 +245,8 @@ module "kuberay-monitoring" {
   create_namespace                = true
   enable_grafana_on_ray_dashboard = var.enable_grafana_on_ray_dashboard
   k8s_service_account             = local.ray_service_account
-  depends_on                      = [module.namespace, module.kuberay-operator, module.kuberay-workload-identity]
+  //TODO(genlu): remove the module.kuberay-operator after migrated using ray addon.
+  depends_on = [module.namespace, module.kuberay-operator, module.kuberay-workload-identity]
 }
 
 module "kuberay-cluster" {
@@ -280,7 +281,7 @@ module "kuberay-cluster" {
   k8s_backend_service_port = var.ray_dashboard_k8s_backend_service_port
   domain                   = var.ray_dashboard_domain
   members_allowlist        = var.ray_dashboard_members_allowlist != "" ? split(",", var.ray_dashboard_members_allowlist) : []
-
+  //TODO(genlu): remove the module.kuberay-operator after migrated using ray addon.
   depends_on = [module.gcs, module.kuberay-operator, module.kuberay-workload-identity]
 }
 

diff --git a/applications/ray/main.tf b/applications/ray/main.tf
@@ -175,7 +175,8 @@ module "kuberay-monitoring" {
   create_namespace                = true
   enable_grafana_on_ray_dashboard = var.enable_grafana_on_ray_dashboard
   k8s_service_account             = local.workload_identity_service_account
-  depends_on                      = [module.kuberay-workload-identity, module.kuberay-operator]
+  //TODO(genlu): remove the module.kuberay-operator after migrated using ray addon.
+  depends_on = [module.kuberay-workload-identity, module.kuberay-operator]
 }
 
 module "gcs" {
@@ -215,7 +216,8 @@ module "kuberay-cluster" {
   k8s_backend_service_port = var.ray_dashboard_k8s_backend_service_port
   domain                   = var.ray_dashboard_domain
   members_allowlist        = var.ray_dashboard_members_allowlist != "" ? split(",", var.ray_dashboard_members_allowlist) : []
-  depends_on               = [module.gcs, module.kuberay-operator, module.kuberay-workload-identity]
+  //TODO(genlu): remove the module.kuberay-operator after migrated using ray addon.
+  depends_on = [module.gcs, module.kuberay-operator, module.kuberay-workload-identity]
 }