Skip to content

Commit

Permalink
update lpg to deploy latest build on new build (#797)
Browse files Browse the repository at this point in the history
* wait to finish latest build before deploying manifests, update sample to ensure build happens first try

* fix sample.tfvars

* terraform fmt
  • Loading branch information
annapendleton committed Sep 4, 2024
1 parent 8027565 commit f743e25
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 3 additions & 2 deletions benchmarks/benchmark/tools/profile-generator/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ resource "google_project_service" "cloudbuild" {
# ----- Manual Benchmarking -----

module "latency-profile" {
count = var.targets.manual != null ? 1 : 0
source = "./modules/latency-profile"
depends_on = [resource.null_resource.build_and_push_image]
count = var.targets.manual != null ? 1 : 0
source = "./modules/latency-profile"

credentials_config = var.credentials_config
namespace = var.namespace
Expand Down
5 changes: 4 additions & 1 deletion benchmarks/benchmark/tools/profile-generator/sample.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ credentials_config = {

project_id = "your_project_id"

namespace = "benchmark"

# Latency profile generator service configuration
build_latency_profile_generator_image = false
# set build_latency_profile_generator_image to false to save 20 min build if no rebuild needed, eg.
# build_latency_profile_generator_image = false
latency_profile_kubernetes_service_account = "prom-frontend-sa"
output_bucket = "your_project_id-benchmark-output-bucket"
k8s_hf_secret = "hf-token"
Expand Down

0 comments on commit f743e25

Please sign in to comment.