Ray TPU Webhook Autoscaling Changes #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
2 times, most recently
from
df06001
to
be4a759
Compare
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
6 times, most recently
from
f3240c2
to
6c0e411
Compare
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
from
f0dbd31
to
35a5815
Compare
richardsliu
reviewed
Mar 7, 2024
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
from
3bba6be
to
691f2bd
Compare
richardsliu
approved these changes
Mar 8, 2024
|
/gcbrun |
2 tasks
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
from
8a74e2c
to
f458b84
Compare
|
/gcbrun |
ryanaoleary
force-pushed
the
kuberay-tpu-env-injector
branch
from
f458b84
to
993dffd
Compare
|
/gcbrun |
annapendleton
pushed a commit
to annapendleton/ai-on-gke
that referenced
this pull request
Mar 26, 2024
* Changed Ray worker template to use numOfHosts * Use numOfHosts when checking workers match topology * Generate DNS hostnames using numOfHosts * Update go pkgs for kuberay CRD changes * numOfHosts -> NumOfHosts and better var names * Go version 1.22 -> 1.21 * Allow kuberay tpu webhook address to be configured * numOfHosts -> NumOfHosts and better var names * Allow kuberay tpu webhook address to be configured * Generate hostnames for multi-host replicas * Kuberay v1.1 Refactoring * Add Pod deletion logic to webhook * go fmt changes * Inject pod affinity and anti-affinity labels * Use ray-operator v1.1.0-rc.0 * Update image tags to 1.1 for new changes * Update documentation for v1.1 changes * Remove headless service creation from terraform (now done by ray-operator) * Remove duplicate path var * Add check for RayCluster name in getReplicaIndex * Change isRunning bool to isCreated * Update documentation to specify versions * Add in check for v5e TPU pods * Default chipsPerHost to 4 * Update prerequisites in README * Simplify podAffinity injection --------- Co-authored-by: Spencer Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Ray TPU Webhook to be compatible with Kuberay CRD changes (ray-project/kuberay#1834, ray-project/kuberay#1920, ray-project/kuberay#1913) in order to support TPU pod autoscaling. This PR has been manually tested by deploying the webhook, creating a RayCluster with
replicas = 2andnumOfHosts = 2and verifying that 4 pods were scaled up and that the webhook correctly injects all labels, pod affinity constraints, and unique environment vars for each slice.