update infrastructure module #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
umeshkumhar
commented
Feb 22, 2024
umeshkumhar
commented
- simplify infra module
imreddy13
reviewed
Feb 22, 2024
| @@ -35,7 +35,7 @@ create_service_account = true | |||
| gcp_service_account = "jupyter-service-account" | |||
|
|
|||
| # Jupyterhub with IAP | |||
| add_auth = true | |||
| add_auth = false | |||
|
|
||
| all_node_pools_tags = ["gke-node", "ai-on-gke"] | ||
|
|
||
| create_network = true |
| create_network = true | ||
| network_name = "ml-network" | ||
| subnetwork_name = "ml-subnet1" | ||
| subnetwork_cidr = "10.100.0.0/16" |
There was a problem hiding this comment.
does this still have the limitation of only 1 cluster per network due to IP space?
There was a problem hiding this comment.
it can have more clusters as well in same network
| @@ -37,7 +37,7 @@ resource "helm_release" "iap_jupyter" { | |||
| chart = "${path.module}/charts/iap_jupyter/" | |||
| namespace = var.namespace | |||
| create_namespace = !contains(data.kubernetes_all_namespaces.allns.namespaces, var.namespace) | |||
|
|
|||
| timeout = 1200 | |||
There was a problem hiding this comment.
maybe leave a comment explaining why it's needed
There was a problem hiding this comment.
helm install takes time.. because of autopilot pod scheduling may take addtional time..
and if pods are not running within 5 minutes tf apply will fail
| @@ -90,6 +90,7 @@ resource "helm_release" "jupyterhub" { | |||
| namespace = var.namespace | |||
| create_namespace = !contains(data.kubernetes_all_namespaces.allns.namespaces, var.namespace) | |||
| cleanup_on_fail = "true" | |||
| timeout = 1200 | |||
imreddy13
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.