Add BlueprintMetadata manifests for jupyter and rag modules, update cluster creation logic in infrastructure so it can be used by IM #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
umeshkumhar
commented
Feb 23, 2024
•
umeshkumhar
commented
- Add Jupyter and RAG app blueprint files
- Restructure code so modules have complete paths
- Enable cloud SQL API by default
- Fix cluster creation in /infrastructure
umeshkumhar
requested review from
imreddy13,
hsachdevah and
blackzlq
and removed request for
imreddy13 and
hsachdevah
imreddy13
changed the title
andrewsykim
changed the title
imreddy13
reviewed
Feb 27, 2024
imreddy13
reviewed
Feb 28, 2024
imreddy13
reviewed
Feb 28, 2024
imreddy13
changed the title
imreddy13
approved these changes
Feb 28, 2024
Your change isn't using complete paths, it's using URLs. This breaks local development, as it's pulling modules from github HEAD. |
artemvmin
added a commit
to artemvmin/ai-on-gke
that referenced
this pull request
Feb 28, 2024
URLs introduced in GoogleCloudPlatform#228
artemvmin
added a commit
to artemvmin/ai-on-gke
that referenced
this pull request
Feb 28, 2024
URLs introduced in GoogleCloudPlatform#228
|
@umeshkumhar this PR broke the presubmit tests because it renamed the gcp_and_k8s_service_account field. Can you please fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.