Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ML platform reference architecture in the folder ml-platform #266

Merged
merged 39 commits into from
Mar 30, 2024

Conversation

gushob21
Copy link
Collaborator

This PR adds a new folder named ml-platform. The new folder contains TF code and README files to help you create a GKE platform that facilitate Machine Learning.

@kenthua
Copy link
Collaborator

kenthua commented Feb 29, 2024

/gcbrun

Copy link
Collaborator

@arueth arueth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run terraform fmt on the Terraform files?

ml-platform/01_gcp_project/variables.tf Outdated Show resolved Hide resolved
ml-platform/01_gcp_project/variables.tf Outdated Show resolved Hide resolved
ml-platform/02_gke/modules/cloud-nat/versions.tf Outdated Show resolved Hide resolved
ml-platform/02_gke/modules/cluster/gke.tf Outdated Show resolved Hide resolved
@arueth
Copy link
Collaborator

arueth commented Mar 6, 2024

I formatted the files and pushed a commit to the branch.

@arueth
Copy link
Collaborator

arueth commented Mar 13, 2024

/gcbrun

@arueth
Copy link
Collaborator

arueth commented Mar 15, 2024

/gcbrun

@arueth arueth force-pushed the mlops-platform branch 2 times, most recently from 820e4ba to 1f0c6fc Compare March 28, 2024 15:26
@arueth arueth force-pushed the mlops-platform branch 4 times, most recently from 849e106 to 8180876 Compare March 29, 2024 19:18
gushob21 and others added 14 commits March 29, 2024 19:20
* Fixing project_id defaults
* Fixing documentation
* Adding default single env installation and updated documentation
* Updated folder structure

* Added steps to for Terraform apply and destory

* Enabled image streaming

* Moved acm-templates to the correct folder

* Modified git token command to remove new lines

* Cleaned up main.tf and fixed issue with create_cluster_yamls.sh

* Cleaned up create_git_cred.sh

* Cleaned up install_kuberay_operator.sh

* Cleaned up create_namespace.sh and fixed and issue with the templates

* Cleaned up install_ray_cluster.sh

* Removed unnecessary outputs

* Bringing in changes from PR #332
@arueth
Copy link
Collaborator

arueth commented Mar 29, 2024

/gcbrun

@arueth arueth marked this pull request as ready for review March 29, 2024 22:17
@arueth arueth enabled auto-merge (squash) March 29, 2024 22:18
Copy link
Collaborator

@alizaidis alizaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arueth arueth self-requested a review March 29, 2024 22:24
@arueth arueth force-pushed the mlops-platform branch 5 times, most recently from d7330e8 to bba2939 Compare March 29, 2024 23:05
@arueth
Copy link
Collaborator

arueth commented Mar 29, 2024

/gcbrun

@arueth arueth requested a review from alizaidis March 29, 2024 23:10
@arueth arueth disabled auto-merge March 29, 2024 23:36
@arueth
Copy link
Collaborator

arueth commented Mar 29, 2024

/gcbrun

Copy link
Collaborator

@alizaidis alizaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arueth arueth enabled auto-merge (squash) March 30, 2024 00:19
@arueth arueth merged commit b9ca547 into main Mar 30, 2024
8 checks passed
@arueth arueth deleted the mlops-platform branch March 30, 2024 02:48
@karajendran
Copy link
Collaborator

LGTM

kfswain pushed a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Aaron Rueth <[email protected]>
Co-authored-by: Kent Hua <[email protected]>
Co-authored-by: Kavitha Rajendran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants