[TPU Provisioner] Bump node pool deletion check interval #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
danielvegamyhre
force-pushed
the
del-interval
branch
from
e38ad02
to
6fdce06
Compare
danielvegamyhre
force-pushed
the
del-interval
branch
from
6fdce06
to
eee5967
Compare
thebinaryone1
approved these changes
Mar 8, 2024
umeshkumhar
pushed a commit
that referenced
this pull request
Mar 11, 2024
bump deletion interval in tpu provisioner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow for more time for Jobs (and pods) to be recreated upon JobSet restart, since JobSet now uses foreground deletion to avoid other issues, so Job recreation is blocked until all of the pods from the previous Job are completely deleted. This means it may take longer than 4 seconds for the pods to begin rescheduling during failure recovery, so we should bump the interval to 60 seconds.