Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TF dependencies to fix TF plan timing issue #284

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

umeshkumhar
Copy link
Collaborator

@umeshkumhar umeshkumhar commented Mar 5, 2024

  • Update frontend explicit depends_on which are not required
  • Remove terraform provider that are not required in frontend
  • update create_namespace to always true, because helm_release will take care if ns already exists and it wont attempt already exists error.

@umeshkumhar
Copy link
Collaborator Author

/gcbrun

applications/rag/main.tf Show resolved Hide resolved
@umeshkumhar
Copy link
Collaborator Author

/gcbrun

@umeshkumhar
Copy link
Collaborator Author

/gcbrun

@umeshkumhar umeshkumhar changed the title update TF dependencies to fix TF plan timing issue Update TF dependencies to fix TF plan timing issue Mar 5, 2024
@artemvmin
Copy link
Collaborator

Could you please document what dependencies are being updated?

Additionally could you please document all the other bug fixes and changes being made? Generally, a person reading through the commit log and/or PR list shouldn't have to read the code to understand the changes that have been made. This also helps the reviewer understand what your intention is with the PR. For example, the following don't seem to be related to your PR title Update TF dependencies to fix TF plan timing issue:

  • ClientIP -> ClusterIP typo
  • Namespace is now always being created in some modules
    • Do we need this and does this have to be done in this PR? Let's reduce the scope to make sure we fix the timing issue completely.

@umeshkumhar umeshkumhar merged commit 58361e0 into main Mar 5, 2024
6 checks passed
artemvmin added a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants