Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Cloud SQL DB creds for notebook and frontend #295

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Cleanup Cloud SQL DB creds for notebook and frontend #295

merged 1 commit into from
Mar 7, 2024

Conversation

imreddy13
Copy link
Collaborator

@imreddy13 imreddy13 commented Mar 6, 2024 •
edited
Loading

  1. Use a k8s secret for DB creds
  2. Mount k8s secret in volumes for Ray & frontend pods
  3. Read the mounted secret volume from the Ray job script in the notebook and from the frontend container
  4. Remove unecessesary DB cred variables from the notebook
  5. Fix bug with NLP/DLP imports

artemvmin
artemvmin approved these changes Mar 6, 2024
View reviewed changes
applications/rag/README.md Outdated Show resolved Hide resolved
@imreddy13 imreddy13 requested a review from bjornsen March 6, 2024 23:04
bjornsen
bjornsen reviewed Mar 6, 2024
View reviewed changes
applications/rag/README.md Outdated Show resolved Hide resolved
@imreddy13 imreddy13 changed the title Move notebook vars to single location & pass them to Ray runtime env Cleanup Cloud SQL DB creds from notebook and frontend Mar 7, 2024
@imreddy13 imreddy13 changed the title Cleanup Cloud SQL DB creds from notebook and frontend Cleanup Cloud SQL DB creds for notebook and frontend Mar 7, 2024
@imreddy13 imreddy13 requested a review from blackzlq March 7, 2024 07:32
@imreddy13 imreddy13 force-pushed the fix-nb branch 2 times, most recently from 5e0cf29 to 251f37e Compare March 7, 2024 08:01
@imreddy13 imreddy13 requested a review from bjornsen March 7, 2024 17:34
@imreddy13
Copy link
Collaborator Author

/gcbrun

@imreddy13
Cleanup Cloud SQL DB creds
638c280 
1) Use a k8s secret for DB creds
2) Mount k8s secret in volumes for Ray & frontend pods
3) Read the mounted secret volume from the Ray job script in the notebook and from the frontend container
4) Remove unecessesary DB cred variables from the notebook
5) Fix import bug with NLP/DLP
@imreddy13
Copy link
Collaborator Author

/gcbrun

1 similar comment
@imreddy13
Copy link
Collaborator Author

/gcbrun

@imreddy13 imreddy13 merged commit 775407b into main Mar 7, 2024
7 checks passed
@imreddy13 imreddy13 deleted the fix-nb branch March 7, 2024 23:56
@imreddy13 imreddy13 mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackzlq blackzlq blackzlq approved these changes

@bjornsen bjornsen bjornsen approved these changes

@umeshkumhar umeshkumhar Awaiting requested review from umeshkumhar

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@hsachdevah hsachdevah Awaiting requested review from hsachdevah

@artemvmin artemvmin Awaiting requested review from artemvmin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imreddy13 @bjornsen @artemvmin @blackzlq