Add github actions for tf lint check #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
umeshkumhar
commented
Mar 6, 2024
umeshkumhar
commented
- Add github actions for TF fmt, TF validate and TF init
umeshkumhar
force-pushed
the
githubactions
branch
from
0ce61b6
to
9cf90cb
Compare
|
/gcbrun |
|
/gcbrun |
blackzlq
reviewed
Mar 6, 2024
|
/gcbrun |
|
/gcbrun |
blackzlq
approved these changes
Mar 6, 2024
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
andrewsykim
reviewed
Mar 6, 2024
| terraform -chdir=applications/ray init | ||
| terraform -chdir=applications/jupyter init | ||
|
|
||
| - name: Terraform Validate |
There was a problem hiding this comment.
We already do this check in cloud build
| with: | ||
| terraform_version: "1.5.7" | ||
|
|
||
| - name: Terraform fmt |
There was a problem hiding this comment.
Can you just add this lint check to cloudbuild.yaml and remove the github actions workflow? I don't think we're at a point where we want to manage both cloudbuild and github actions for presubmit.
There was a problem hiding this comment.
(also because cloudbuild is a blocking pre-submit now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.