Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CI #303

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Optimize CI #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
414f618
upgrade machineType
hsachdevah Mar 6, 2024
5cf747c
pinned workload-identity module to fix for sa bug
hsachdevah Mar 6, 2024
5055e60
Modified all occurances of WI module
hsachdevah Mar 7, 2024
cbd9cb4
remove automount_service_account_token from kuberay-operator
hsachdevah Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions applications/rag/frontend/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ module "iap_auth" {

module "frontend-workload-identity" {
source = "terraform-google-modules/kubernetes-engine/google//modules/workload-identity"
version = "30.0.0" # Pinning to a previous version as current version (30.1.0) showed inconsitent behaviour with workload identity service accounts
use_existing_gcp_sa = !var.create_service_account
name = var.google_service_account
namespace = var.namespace
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,4 +363,4 @@ substitutions:
_USER_NAME: github
options:
substitutionOption: 'ALLOW_LOOSE'

machineType: 'E2_HIGHCPU_8'
1 change: 1 addition & 0 deletions modules/jupyter/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ module "iap_auth" {

module "jupyterhub-workload-identity" {
source = "terraform-google-modules/kubernetes-engine/google//modules/workload-identity"
version = "30.0.0" # Pinning to a previous version as current version (30.1.0) showed inconsitent behaviour with workload identity service accounts
name = var.workload_identity_service_account
namespace = var.namespace
project_id = var.project_id
Expand Down
3 changes: 1 addition & 2 deletions modules/kuberay-operator/kuberay.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ resource "helm_release" "kuberay-operator" {

module "kuberay-workload-identity" {
source = "terraform-google-modules/kubernetes-engine/google//modules/workload-identity"
version = "30.0.0" # Pinning to a previous version as current version (30.1.0) showed inconsitent behaviour with workload identity service accounts
use_existing_gcp_sa = !var.create_service_account
name = var.google_service_account
namespace = var.namespace
project_id = var.project_id
roles = ["roles/cloudsql.client", "roles/monitoring.viewer"]

automount_service_account_token = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this broke the RAG application. See: 6b844bc#r139575280


depends_on = [helm_release.kuberay-operator]
}

Expand Down
Loading