Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write back dlio result to a separate result bucket and add parser script #313

Merged
merged 1 commit into from
Mar 12, 2024
Merged

write back dlio result to a separate result bucket and add parser script #313

merged 1 commit into from
Mar 12, 2024

Conversation

leiyiz
Copy link
Collaborator

@leiyiz leiyiz commented Mar 6, 2024

this PR

  • changes the DLIO job to automatically write back the results of DLIO runs to a second result bucket.
  • added a python script to help walk the result folder tree and calculate average performance metrics across multiple pods' results.

@leiyiz leiyiz force-pushed the main branch 3 times, most recently from b2a5ed4 to 10cbcdc Compare March 11, 2024 20:04
dannawang0221
dannawang0221 reviewed Mar 11, 2024
View reviewed changes
benchmarks/benchmark/tools/dlio/modules/dlio/podspec.tpl Show resolved Hide resolved
benchmarks/benchmark/tools/dlio/modules/dlio/podspec.tpl Show resolved Hide resolved
benchmarks/benchmark/tools/dlio/parser.py Outdated Show resolved Hide resolved
benchmarks/benchmark/tools/dlio/parser.py Outdated Show resolved Hide resolved
benchmarks/benchmark/tools/dlio/parser.py Outdated Show resolved Hide resolved
benchmarks/benchmark/tools/dlio/parser.py Outdated Show resolved Hide resolved
@leiyiz
Copy link
Collaborator Author

leiyiz commented Mar 11, 2024

/gcbrun

@dannawang0221
Copy link
Collaborator

/lgtm

@dannawang0221
Copy link
Collaborator

/approve

@richardsliu richardsliu merged commit f6e5d41 into GoogleCloudPlatform:main Mar 12, 2024
3 checks passed
annapendleton pushed a commit to annapendleton/ai-on-gke that referenced this pull request Mar 26, 2024
@leiyiz @annapendleton
write back dlio result to a separate result bucket and add parser scr…
394eee1 
…ipt (GoogleCloudPlatform#313)

write back dlio result to a separate result bucket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannawang0221 dannawang0221 dannawang0221 left review comments

@saikat-royc saikat-royc saikat-royc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiyiz @dannawang0221 @saikat-royc @richardsliu