Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for AutoPilot clusters #315

Merged
merged 13 commits into from
Mar 18, 2024
Merged

CI for AutoPilot clusters #315

merged 13 commits into from
Mar 18, 2024

Conversation

hsachdevah
Copy link
Collaborator

Created cloudbuild-ap.yaml file to be used for another CB trigger to test deployments on AP cluster

@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah hsachdevah marked this pull request as ready for review March 7, 2024 16:56
@hsachdevah hsachdevah changed the title Cloudbuild for AutoPilot clusters CI for AutoPilot clusters Mar 7, 2024
@hsachdevah
Copy link
Collaborator Author

ToDo: Add steps to create & cleanup AP cluster.

@hsachdevah hsachdevah self-assigned this Mar 7, 2024
cloudbuild-ap.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already considered trying to support both standard/autopilot in a single cloudbuild.yaml file? I haven't inspected the changes in detail yet to understand the trade-offs

@andrewsykim
Copy link
Collaborator

Also, is the plan to have a separate cloudbuild trigger for cloudbuild-ap.yaml? Will that be a blocking presubmit too?

@hsachdevah
Copy link
Collaborator Author

Also, is the plan to have a separate cloudbuild trigger for cloudbuild-ap.yaml? Will that be a blocking presubmit too?

That's right. Running two parallel build jobs can save some time & can surface cluster specific errors.

Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to consolidate standard/autopilot tests into a single cloudbuild.yaml, but I guess this is not blocking

@hsachdevah hsachdevah force-pushed the autopilot-ci branch 11 times, most recently from ecbff1a to b6cbdec Compare March 14, 2024 20:37
@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah
Copy link
Collaborator Author

/gcbrun

cloudbuild.yaml Outdated Show resolved Hide resolved
modules/jupyter/tests/change_jupyter_config.py Outdated Show resolved Hide resolved
@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah
Copy link
Collaborator Author

/gcbrun

@hsachdevah hsachdevah merged commit f8c0453 into main Mar 18, 2024
9 checks passed
@andrewsykim
Copy link
Collaborator

FYI: #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants