Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #321

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Update README #321

merged 3 commits into from
Mar 11, 2024

Conversation

blackzlq
Copy link
Collaborator

@blackzlq blackzlq commented Mar 8, 2024

  1. Correct the output name.
  2. Add instruction about IAP during setup.

Tested-by: zlq on sandbox

@blackzlq
Update README
f16e382 
1. Correct the output name.
2. Add instruction about IAP during setup.

Tested-by: zlq on sandbox
@blackzlq
Copy link
Collaborator Author

blackzlq commented Mar 8, 2024

/gcbrun

@blackzlq
Copy link
Collaborator Author

/gcbrun

bjornsen
bjornsen approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@bjornsen bjornsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, otherwise LGTM.

applications/rag/README.md Outdated Show resolved Hide resolved
applications/rag/README.md Show resolved Hide resolved
@blackzlq
Add external link
53182df 
fix the index

Tested-by: zlq
@blackzlq
Copy link
Collaborator Author

/gcbrun

@blackzlq blackzlq merged commit 5af7eff into GoogleCloudPlatform:main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemvmin artemvmin artemvmin left review comments

@bjornsen bjornsen bjornsen approved these changes

@imreddy13 imreddy13 Awaiting requested review from imreddy13

@umeshkumhar umeshkumhar Awaiting requested review from umeshkumhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackzlq @bjornsen @artemvmin