Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpu-provisioner: Add support for Spot Node Pools #588

Merged
merged 1 commit into from
Apr 16, 2024
Merged

tpu-provisioner: Add support for Spot Node Pools #588

merged 1 commit into from
Apr 16, 2024

Conversation

nstogner
Copy link
Collaborator

Add support for auto-provisioning of spot node pools.

Pod spec should include a node selector and tolerations:

  nodeSelector:
    cloud.google.com/gke-spot: "true"
   tolerations:
   - key: cloud.google.com/gke-spot
     operator: Equal
     value: "true"
     effect: NoSchedule

@nstogner
Copy link
Collaborator Author

nstogner commented Apr 16, 2024 •
edited
Loading

Tested with go clean -testcache && TEST_SPOT=true go test -timeout 40m -v . via e2e test PR #235.

@danielvegamyhre
Copy link
Contributor

/gcbrun

danielvegamyhre
danielvegamyhre approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@danielvegamyhre danielvegamyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielvegamyhre danielvegamyhre merged commit 179dbad into GoogleCloudPlatform:main Apr 16, 2024
4 checks passed
alpha-amundson pushed a commit that referenced this pull request May 3, 2024
@nstogner @alpha-amundson
tpu-provisioner: Add support for Spot Node Pools (#588)
1b8aec1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre danielvegamyhre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstogner @danielvegamyhre