Fixing issue with package notebook in jupyterhub image. #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
german-grandas
commented
Aug 27, 2024
german-grandas
commented
- Refactoring of code so it can build and install directly the authentication package instead of getting it from github.
- Installing notebook as a separate dependency
- Letting pip install the jupyterhub version according to the notebook package.
- Refactoring of code so it can build and install directly the authentication package
instead of getting it from github.
- Installing notebook as a separate dependency
- Letting pip install the jupyterhub version according to the notebook package.
|
/gcbrun |
|
/gcbrun |
chiayi
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Hi german-grandas, thanks for contributing to the repo! Just have a few questions and comments.
| USER root | ||
| RUN chmod -R u+w ./authenticator | ||
|
|
||
| RUN pip3 install notebook |
There was a problem hiding this comment.
What's the reason for installing the notebook for the hub image?
| license='Apache 2.0', | ||
| install_requires=[ | ||
| "jupyterhub>=4.1.0", | ||
| "jupyterhub", |
There was a problem hiding this comment.
I believe version 4.1.0 contains a fix for a known vulnerability and thats why we have `>=4.1.0"
|
Closing PR, the bug is fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.