Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TPU Provisioner to be configured to copy Pod labels to Node labels #788

Conversation

nstogner
Copy link
Collaborator

Copy configured Pod labels to Node config at Node Pool creation-time.

Configured via GCP_POD_TO_NODE_LABELS, a comma-separated list of label keys.

# NOTE: See the log message to confirm that "abc" and "xyz" are parse to be copied (see "podToNodeLabels" in log message).
GCP_POD_TO_NODE_LABELS=abc,xyz go run ./cmd/main.go
2024-08-28T17:55:00-04:00       INFO    setup   creating gke client     {"project": "", "clusterLocation": "", "cluster": "", "zone": "", "nodeServiceAccount": "", "nodeTags": [], "podToNodeLabels": ["abc", "xyz"]}
2024-08-28T17:55:00-04:00       INFO    setup   starting manager

@nstogner nstogner force-pushed the tpu-provisioner-allow-copying-pod-labels-to-nodes branch from e00d42d to ee9c4c1 Compare September 9, 2024 16:23
@thebinaryone1 thebinaryone1 enabled auto-merge (squash) September 10, 2024 20:23
Copy link

@Ethanlm Ethanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@thebinaryone1 thebinaryone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gcbrun

@thebinaryone1 thebinaryone1 merged commit ba10e41 into GoogleCloudPlatform:main Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants