fix: add vpc cleanup cloudbuild yaml #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu2011
force-pushed
the
genlu/cloud_build
branch
2 times, most recently
from
9004893
to
3394340
Compare
Change-Id: Ia0183c53715e79f5b791fa1e80aa01877cac79cd
genlu2011
force-pushed
the
genlu/cloud_build
branch
from
3394340
to
92ff10a
Compare
|
Are you going to update the cloud build trigger to use the script instead? or you already did |
yiyinglovecoding
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the script to delete leftover VPCs, which only deletes firewall before the fix.
However, to delete a VPC, the linked subnets, firewall, address, peering, route have to be deleted first.
In addition, instead of using inline YAML in gcp console to define the cloud build job, move the script to this repo.