Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lpg to deploy latest build on new build #797

Merged
merged 3 commits into from
Sep 4, 2024
Merged

update lpg to deploy latest build on new build #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a78e88
wait to finish latest build before deploying manifests, update sample…
annapendleton Sep 4, 2024
be3ba37
fix sample.tfvars
annapendleton Sep 4, 2024
b97968a
terraform fmt
annapendleton Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions benchmarks/benchmark/tools/profile-generator/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ resource "google_project_service" "cloudbuild" {
# ----- Manual Benchmarking -----

module "latency-profile" {
count = var.targets.manual != null ? 1 : 0
source = "./modules/latency-profile"
depends_on = [resource.null_resource.build_and_push_image]
count = var.targets.manual != null ? 1 : 0
source = "./modules/latency-profile"

credentials_config = var.credentials_config
namespace = var.namespace
Expand Down
5 changes: 4 additions & 1 deletion benchmarks/benchmark/tools/profile-generator/sample.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ credentials_config = {

project_id = "your_project_id"

namespace = "benchmark"

# Latency profile generator service configuration
build_latency_profile_generator_image = false
# set build_latency_profile_generator_image to false to save 20 min build if no rebuild needed, eg.
# build_latency_profile_generator_image = false
latency_profile_kubernetes_service_account = "prom-frontend-sa"
output_bucket = "your_project_id-benchmark-output-bucket"
k8s_hf_secret = "hf-token"
Expand Down