Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing.md to include description of how to find build logs #800

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Update contributing.md to include description of how to find build logs #800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870f754
Update contributing.md to include description of how to find build logs
gongmax Sep 6, 2024
bf7a9fc
Update contributing.md
gongmax Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,13 @@ Guidelines](https://opensource.google/conduct/).
All submissions, including submissions by project members, require review. We
use [GitHub pull requests](https://docs.github.com/articles/about-pull-requests)
for this purpose.

After creating a PR, a contributor needs to add `/gcbrun` to the comment to trigger CI
gongmax marked this conversation as resolved.
Show resolved Hide resolved
gongmax marked this conversation as resolved.
Show resolved Hide resolved
gongmax marked this conversation as resolved.
Show resolved Hide resolved
for the PR, which includes the CloudBuild triggered e2e test `pr-review-trigger`
and `pr-review-trigger-ap-clusters` as shown below.
![image](https://github.com/user-attachments/assets/6a759456-e1dd-4a3b-95da-84c9f2b8b053)

If any of the build fails, you can find the link to the build log for these triggers at
gongmax marked this conversation as resolved.
Show resolved Hide resolved
the bottom of the details page by clicking `Details` link.


Loading