Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow benchmark to write json output #801

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

richardsliu
Copy link
Collaborator

Modify the serving benchmark to write json output similar to Jetstream benchmark: https://github.com/richardsliu/JetStream/blob/vllm-benchmark/benchmarks/benchmark_serving.py#L648

This will allow the benchmark to integrate with XLML dashboard.

Copy link
Collaborator

@achandrasekar achandrasekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this! Makes it easier to parse the results.

@richardsliu richardsliu merged commit c1633fa into GoogleCloudPlatform:main Sep 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants