Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to Hugging Face DLC for TGI #816

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alvarobartt
Copy link
Collaborator

Description

This PR updates a bunch of outdated references to Text Generation Inference (TGI) container, as previously those were pointing to the GitHub Container Registry where Hugging Face publishes those containers i.e. ghcr.io/huggingface/text-generation-inference; but since the Hugging Face DLCs on Google Cloud were recently released publicly (see Google-Cloud-Containers), now those references have been updated to point to the DLCs hosted on Google Cloud's Artifact Registry.

cc @brandonroyal

Included a harmless TODO note so that we remember to come back to this
once the benchmark is verified with the latest Hugging Face DLC for TGI
cc @annapendleton
@annapendleton
Copy link
Collaborator

/gcbrun

@annapendleton
Copy link
Collaborator

@alvarobartt I also added you as a collaborator so you can test + merge this yourself :)

@alvarobartt
Copy link
Collaborator Author

Hi here @annapendleton, so the CI is failing, but not sure that's something I can fix or related to any of the changes within this PR, could you help me debug the issue further if related to the PR? 🤗

@annapendleton
Copy link
Collaborator

Hi here @annapendleton, so the CI is failing, but not sure that's something I can fix or related to any of the changes within this PR, could you help me debug the issue further if related to the PR? 🤗

From what I can see in the logs, it looks like the test cluster isn't present. We don't use these tests ourselves for the benchmarking, I think we should add someone else who has a better sense of if it's safe to bypass this test or not.

@annapendleton
Copy link
Collaborator

@imreddy13 could you help us determine if this is a true test failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants