fix(deps): update module github.com/googlecloudplatform/cloud-foundation-toolkit/infra/blueprint-test to v0.16.2

[renovate-bot]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test	v0.5.2 -> v0.16.2

---

Configuration

📅 Schedule: Branch creation - "every 1 months on the first day of the month" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[bourgeoisor]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[Shabirmean]

/gcbrun

[dpebot]

/gcbrun

[NimJay]

The error I'm seeing in the failing anthos-samples-int-trigger check (build logs here):

...
/builder/home/go/pkg/mod/k8s.io/[email protected]/pkg/internal/third_party/go-json-experiment/json/arshal_funcs.go:87:1: too many errors
note: module requires Go 1.19
# github.com/zclconf/go-cty/cty/set
/builder/home/go/pkg/mod/github.com/zclconf/[email protected]/cty/set/iterator.go:3:17: syntax error: unexpected any, expecting ]
...
/builder/home/go/pkg/mod/github.com/zclconf/[email protected]/cty/set/ops.go:117:12: too many errors
note: module requires Go 1.18

It sounds like this dependency bump requires Go 1.19.

I believe the Golang version being used by these integration tests is whatever Golang version found in this gcr.io/cloud-foundation-cicd/cft/developer-tools image.

The latest gcr.io/cloud-foundation-cicd/cft/developer-tools image (as of today) uses Golang 1.20:

➜ docker pull gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 # This takes a few minutes because the image is +1GB.
...

➜ docker run --name mycontainer -d -i -t gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 /bin/sh
cd4d145167dd93d10879ae7a81ed1ea1a580eead03d0ae2b44702d640503afa6

➜ docker exec -it mycontainer sh -c "go version"
go version go1.20.7 linux/amd64

➜ docker kill mycontainer

I found the latest image here.

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[NimJay]

We're encountering a different error now (see build logs here):

Error: Unsupported Terraform Core version

  on ../../../anthos-bm-gcp-terraform/versions.tf line 18, in terraform:
  18:   required_version = ">= v0.15.1, < 1.4" # this line should not change during a release

Module module.anthos_bm_gcp (from ../../../anthos-bm-gcp-terraform) does not
support Terraform version 1.5.5. To proceed, either choose another supported
Terraform version or update this version constraint. Version constraints are
normally set for good reason, so updating the constraint may lead to other
errors or unexpected behavior.

Namely, /anthos-bm-gcp-terraform does not allow Terraform 1.4 or lower.

I just checked the Terraform version of the gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 image. It's using Terraform v1.5.5.

docker pull
docker run --name mycontainer -d -i -t gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 /bin/sh
docker exec -it mycontainer sh -c "terraform version"

Terraform v1.5.5

Next step should be:
a. see if we can update all Terraform version constraints to use Terraform 1.5.5 (or above) and continue using gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4
b. see if we can use a version of gcr.io/cloud-foundation-cicd/cft/developer-tools (i.e., downgrade 1.14.4) that contains both Golang 1.19 or higher and Terraform 1.3 or lower.

[dpebot]

/gcbrun

[NimJay]

"Next steps" suggested in my previous comment:
a. see if we can update all Terraform version constraints to use Terraform 1.5.5 (or above) and continue using gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4, or
b. see if we can use a version of gcr.io/cloud-foundation-cicd/cft/developer-tools (i.e., downgrade 1.14.4) that contains both Golang 1.19 or higher and Terraform 1.3 or lower.

We should try a.

We cannot move forward with b. See Google-internal chat thread here. There is no gcr.io/cloud-foundation-cicd/cft/developer-tools image that contains both:

• Golang 1.19 or higher and
• Terraform 1.3 or lower.

[dpebot]

/gcbrun

[bourgeoisor]

Terraform constraint bumped.

This is the error now:

Error: No value for required variable
  on variables.tf line 17:
  17: variable "editor_project_id" {

Error: No value for required variable
  on variables.tf line 21:
  21: variable "editor_sa_key_file_path" {

It's complaining about these variables that are not set with any values: https://github.com/GoogleCloudPlatform/anthos-samples/blob/main/test/fixtures/abm_gce_defaults_on_editor_project/variables.tf#L17-L23

I assume they should be set here: https://github.com/GoogleCloudPlatform/anthos-samples/blob/main/test/setup/outputs.tf#L19-L34

This is the PR that added those tests: #39

[bourgeoisor]

@Shabirmean just reading the last comment, any thoughts? I'm not sure how those tests work, and why those outputs are not working as intended anymore.

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[forking-renovate]

ℹ Artifact update notice

File name: test/integration/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

• 31 additional dependencies were updated
• The go directive was updated for compatibility reasons

Details:

Package	Change
go	1.19 -> 1.23.1
github.com/stretchr/testify	v1.8.4 -> v1.9.0
cloud.google.com/go	v0.110.2 -> v0.110.7
cloud.google.com/go/compute	v1.19.2 -> v1.23.0
cloud.google.com/go/iam	v1.0.1 -> v1.1.2
cloud.google.com/go/storage	v1.30.1 -> v1.33.0
github.com/aws/aws-sdk-go	v1.44.260 -> v1.45.5
github.com/davecgh/go-spew	v1.1.1 -> v1.1.2-0.20180830191138-d8f796af33cc
github.com/go-errors/errors	v1.4.2 -> v1.5.0
github.com/go-openapi/jsonpointer	v0.19.6 -> v0.20.0
github.com/go-openapi/swag	v0.22.3 -> v0.22.4
github.com/google/go-cmp	v0.5.9 -> v0.6.0
github.com/google/s2a-go	v0.1.3 -> v0.1.7
github.com/google/uuid	v1.3.0 -> v1.3.1
github.com/googleapis/enterprise-certificate-proxy	v0.2.3 -> v0.2.5
github.com/googleapis/gax-go/v2	v2.8.0 -> v2.12.0
github.com/gruntwork-io/terratest	v0.41.23 -> v0.47.1
github.com/hashicorp/go-getter	v1.7.5 -> v1.7.6
github.com/hashicorp/hcl/v2	v2.16.2 -> v2.20.1
github.com/klauspost/compress	v1.16.5 -> v1.16.7
github.com/mitchellh/go-testing-interface	v1.14.2-0.20210217184823-a52172cd2f64 -> v1.14.2-0.20210821155943-2d9075ca8770
github.com/pmezard/go-difflib	v1.0.0 -> v1.0.1-0.20181226105442-5d4384ee4fb2
github.com/tidwall/gjson	v1.14.4 -> v1.17.3
github.com/tmccombs/hcl2json	v0.5.0 -> v0.6.0
github.com/zclconf/go-cty	v1.13.1 -> v1.14.4
golang.org/x/mod	v0.10.0 -> v0.21.0
golang.org/x/oauth2	v0.8.0 -> v0.12.0
google.golang.org/api	v0.122.0 -> v0.138.0
google.golang.org/appengine	v1.6.7 -> v1.6.8
google.golang.org/genproto	v0.0.0-20230410155749-daa745c078e1 -> v0.0.0-20230822172742-b8732ec3820d
k8s.io/kube-openapi	v0.0.0-20230501164219-8b0f38b5fd1f -> v0.0.0-20231010175941-2dd684a91f00
sigs.k8s.io/kustomize/kyaml	v0.14.2 -> v0.17.2

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun