Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add user cluster create with terraform sample (manuallb) #594

Merged
merged 31 commits into from
Aug 25, 2023

Conversation

Shabirmean
Copy link
Member

@Shabirmean Shabirmean commented Apr 11, 2023

Fixes b/270587524

Description

  • Adds a new sample for creating Anthos on bare metal user cluster with ManualLB using the Terraform provider.

Change summary

  • Add new directory under anthos-onprem-terraform called abm_user_cluster_manuallb
  • Add a new sample for creating a user cluster with manuallb

Related PRs/Issues

  • N/A

@Shabirmean Shabirmean requested a review from a team as a code owner April 11, 2023 03:32
@snippet-bot
Copy link

snippet-bot bot commented Apr 11, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 11, 2023
@bourgeoisor
Copy link
Member

│ Error: Failed to query available provider packages
│ 
│ Could not retrieve the list of available versions for provider
│ hashicorp/google-private: provider registry registry.terraform.io does not
│ have a provider named registry.terraform.io/hashicorp/google-private

@Shabirmean
Copy link
Member Author

Shabirmean commented Apr 11, 2023

│ Error: Failed to query available provider packages
│ 
│ Could not retrieve the list of available versions for provider
│ hashicorp/google-private: provider registry registry.terraform.io does not
│ have a provider named registry.terraform.io/hashicorp/google-private

We will be seeing this error until the Terraform provider is public previewed next week. Currently testable only internally!

@Shabirmean Shabirmean added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 12, 2023
@Shabirmean Shabirmean added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 2, 2023
Base automatically changed from abm-tf-user-cluster-sample to main May 15, 2023 23:34
@Shabirmean Shabirmean requested a review from a team as a code owner May 15, 2023 23:34
@Shabirmean Shabirmean removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 30, 2023
@Shabirmean
Copy link
Member Author

@naitianliu-google - Can you TAL at this and confirm if we can merge this in?

@Shabirmean Shabirmean enabled auto-merge (squash) August 25, 2023 19:02
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shabirmean Shabirmean merged commit 8b94673 into main Aug 25, 2023
16 checks passed
@Shabirmean Shabirmean deleted the abm-tf-user-cluster-sample-mlb branch August 25, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants