App Scaffold #478
Merged
App Scaffold #478
+463
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sanjanalreddy
approved these changes
Jun 4, 2024
| @@ -0,0 +1,19 @@ | |||
| # This file specifies files that are *not* uploaded to Google Cloud | |||
There was a problem hiding this comment.
not -> should not be
|
|
||
| The workflow described here works from CloudShell or any node with the [gcloud CLI](https://cloud.google.com/sdk/docs/install) has been properly installed and authenticated. | ||
|
|
||
| This means that you can develop your application fully locally on your laptop for example, as long as you have run `make auth` after installing the [gcloud CLI](https://cloud.google.com/sdk/docs/install) on it. |
| @@ -0,0 +1,51 @@ | |||
| async function queryApi(prompt) { | |||
There was a problem hiding this comment.
Add a comment at the top of this file to describe what this file is doing. Since there's so many files it'll be good to know what the purpose of this file is.
takumiohym
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM! Left a minor comment.
Also, I think it's better to name the directory under scaffolds to more specific name instead of generic app_engine so that we can add more scaffolding examples here. @BenoitDherin
|
|
||
|
|
||
| @app.route("/myapp", methods=["GET"]) | ||
| def _answernaut(): |
There was a problem hiding this comment.
Maybe remove this internal code name and use more generic one?
There was a problem hiding this comment.
I'll do both! Thanks @takumiohym .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first part of an app scaffold to be deployed on AppEngine.
It contains:
./app/static./scriptsMakefilewith targets to create the virtual environment (make venv), to run the app locally (make run), to deploy the app on AppEngine withmake deploy.make testsFor now, the app is dummy, returning to the user only what the user enters. The app logic will come as a follow-up PR.
Testing notes: Test the app locally on your laptop or on CloudShell following the step in the
README.md. (For CloudShell skip the instructions about installing and authenticating the gcloud CLI.)