Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump locust deps #612

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Bump locust deps #612

merged 1 commit into from
Feb 9, 2022

Conversation

bourgeoisor
Copy link
Member

This was an attempt at fixing a memory leak issue with the load generator (#520). Unfortunately it didn't help, but this version bump is necessary nonetheless due to #599.

I have tested this on a live cluster-- The load generator works as intended (bar the memory leak of course).

More details in #520.

@bourgeoisor bourgeoisor requested a review from a team February 9, 2022 16:59
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

🚀 PR staged at http://35.184.86.193

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick smoke test of the staging URL (e.g., deposited/transferred funds).
Looks good to me!
Approved.

@@ -1,50 +1,74 @@
#
# This file is autogenerated by pip-compile
# This file is autogenerated by pip-compile with python 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought:
The Dockerfile for the loadgenerator service uses python3.7 — but I doubt this will be an issue.

RUN virtualenv -p python3.7 /env

@bourgeoisor bourgeoisor merged commit d5e9071 into main Feb 9, 2022
@bourgeoisor bourgeoisor deleted the issue-520-loadgen-memleak branch February 9, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants