Add Alerts, Logging, Channels Factories

[joshw123]

---

Checklist

I applicable, I acknowledge that I have:

• Read the contributing guide
• Ran terraform fmt on all modified files
• Regenerated the relevant README.md files using tools/tfdoc.py
• Made sure all relevant tests pass

[juliocc]

@joshw123 this is great stuff!

I left comments below, but besides that:

1. We need to update project/README.md to include examples the new variables and factories
2. FAST tests need to be updated

I have a few more things, but let's start with this batch.

[joshw123]

@joshw123 this is great stuff!

I left comments below, but besides that:

1. We need to update project/README.md to include examples the new variables and factories
2. FAST tests need to be updated

I have a few more things, but let's start with this batch.

Thank You, Ill look at the above, Im checking through all the fields too to ensure optional and required match the docs, and to include validation where necessary :)

[joshw123]

@ludoo @juliocc The only two tests that are still not passing are Module Examples Test report

examples.test_plan.test_example[terraform:modules/project-factory:Example:1]
AssertionError: wrong number of resources
assert 56 == 59

examples.test_plan.test_example[terraform:modules/project-factory:Tests:1]
AssertionError: wrong number of resources
assert 22 == 25

I don't know if its just me, but I can't seem to see where it is getting them values, could you point me in the right direction please? :)

Thank You.

[juliocc]

examples.test_plan.test_example[terraform:modules/project-factory:Example:1] AssertionError: wrong number of resources assert 56 == 59

Look at the #tftest tag at the end of the code block in this section.

examples.test_plan.test_example[terraform:modules/project-factory:Tests:1] AssertionError: wrong number of resources assert 22 == 25

Same thing here.

Take a look at the contributing guide for more details.

[ludoo]

Can you sign the CLA from the ju****c​@gmail.com account?

[juliocc]

Can you sign the CLA from the ju****c​@gmail.com account?

That address is mine. Should be fixed now.

[juliocc]

@joshw123 I'll do my second pass today. Apologies for the delay.

[juliocc]

Leaving a few more comments below.

I also sent you a PR against your branch with a few styling fixes. Once you get that merged I'll try to get started on removing the default_alerts_email variable and use essential_contacts

[juliocc]

I updated this PR to change only modules/project and modueles/project-factory. I'll send a separate PR for FAST

[ludoo]

Awesome stuff. Can we wait a couple of days for fast and do it in fast dev, as I'm almost ready to send a large pr there...

[juliocc]

Awesome stuff. Can we wait a couple of days for fast and do it in fast dev, as I'm almost ready to send a large pr there...

Absolutely. That's why I removed the fast part.

[joshw123]

Thank You for finishing this @juliocc @ludoo Apologies for being absent, I have been in hospital with Flu and with Christmas and everything totally forgot, thank you again :)