Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificate-manager): reference dns_authz by fully qualified id #2833

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

frits-v
Copy link
Collaborator

@frits-v frits-v commented Jan 22, 2025

Closes #2832


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@frits-v frits-v force-pushed the fix/certman-dns-authz branch 3 times, most recently from 01499fa to 700719a Compare January 22, 2025 16:35
@ludoo ludoo enabled auto-merge (squash) January 22, 2025 16:44
@frits-v
Copy link
Collaborator Author

frits-v commented Jan 22, 2025

@ludoo -- I'll work to make sure the tests pass

@ludoo ludoo disabled auto-merge January 22, 2025 19:46
@frits-v frits-v force-pushed the fix/certman-dns-authz branch 3 times, most recently from 42d21e2 to 4e79549 Compare January 22, 2025 20:10
@frits-v frits-v force-pushed the fix/certman-dns-authz branch from 4e79549 to 2cbb652 Compare January 22, 2025 20:41
@frits-v frits-v enabled auto-merge (squash) January 22, 2025 20:41
@frits-v frits-v requested a review from ludoo January 22, 2025 21:46
@frits-v frits-v merged commit 43e6dac into GoogleCloudPlatform:master Jan 22, 2025
14 checks passed
@frits-v frits-v deleted the fix/certman-dns-authz branch January 22, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certificate-manager dns_authorization needs to be referenced by id
2 participants