-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): [gke-optimization] Update module github.com/golang/glog to v1.2.4 [SECURITY] #149
base: main
Are you sure you want to change the base?
Conversation
…to v1.2.4 [SECURITY]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by Renovate bot, updates the github.com/golang/glog
dependency from version v1.1.0
to v1.2.4
in the projects/gke-optimization/binpacker/api
directory. This is a security update addressing CVE-2024-45339, which allows an attacker to overwrite sensitive files if logs are written to a widely-writable directory. The update includes several bug fixes and improvements detailed in the release notes linked in the PR description. The primary change is that glog now exits with status code 2 if the log file already exists, mitigating the vulnerability.
Here's a breakdown of the changes:
- Intent: Address a security vulnerability (CVE-2024-45339) and incorporate bug fixes in the
glog
library. - Changes: The
go.mod
file inprojects/gke-optimization/binpacker/api
has been updated to reflect the new version ofgithub.com/golang/glog
(fromv1.1.0
tov1.2.4
). - Activity: The PR was automatically generated by Renovate bot and is awaiting manual merge.
The specific changes in go.mod
are:
Line | Before | After |
---|---|---|
9 | github.com/golang/glog v1.1.0 |
github.com/golang/glog v1.2.4 |
I'll provide a more detailed review shortly.
A little haiku to brighten your day:
Code flows like a stream,
Fixes merge, a gentle hum,
Security's peace found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request updates the github.com/golang/glog
module to v1.2.4, addressing a security vulnerability (CVE-2024-45339). This is a necessary update and should be merged as soon as possible. The change is well-isolated to the go.mod
file, making the review straightforward. I have reviewed the release notes and the change looks good. Since this is a security update, thorough testing is recommended after merging.
This PR contains the following updates:
v1.1.0
->v1.2.4
GitHub Vulnerability Alerts
CVE-2024-45339
When logs are written to a widely-writable directory (the default), an unprivileged attacker may predict a privileged process's log file path and pre-create a symbolic link to a sensitive file in its place. When that privileged process runs, it will follow the planted symlink and overwrite that sensitive file. To fix that, glog now causes the program to exit (with status code 2) when it finds that the configured log file already exists.
Release Notes
golang/glog (github.com/golang/glog)
v1.2.4
Compare Source
What's Changed
Full Changelog: golang/glog@v1.2.3...v1.2.4
v1.2.3
Compare Source
What's Changed
Full Changelog: golang/glog@v1.2.2...v1.2.3
v1.2.2
Compare Source
What's Changed
Full Changelog: golang/glog@v1.2.1...v1.2.2
v1.2.1
Compare Source
What's Changed
Full Changelog: golang/glog@v1.2.0...v1.2.1
v1.2.0
Compare Source
What's Changed
Full Changelog: golang/glog@v1.1.2...v1.2.0
v1.1.2
Compare Source
Bugfix release.
What's Changed
Full Changelog: golang/glog@v1.1.1...v1.1.2
v1.1.1
Compare Source
Bugfixes since the larger v1.1.0, which have been addressed.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.