Switch default implementation to v2 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
reviewed
Jul 9, 2021
| ``` | ||
| **Example:** | ||
|
|
||
| ## gRPC-based driver (v1) |
There was a problem hiding this comment.
What's the rationale for still including v1? When is it going to be removed?
There was a problem hiding this comment.
We can just remove it as part of this change, I suppose. There is no instance in which we'd want customers using v1.
dzou
approved these changes
Jul 9, 2021
Co-authored-by: Daniel Zou <[email protected]>
Co-authored-by: Daniel Zou <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threadPoolSizesettings from V2.Biggest change is in the docs. We'll do more passes over the docs, but it would be good to validate that they are coherent.