Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated github action commands. #693

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 2, 2023

  1. Github action shows warning:
    The `set-output` command is deprecated and will be disabled soon.
    sample log
    This change follows the upgrade guide and upgrades to using Environment Files

  2. This pr also addresses Node.js 12 actions are deprecated warning on unit test and integration tests.
    Github action announcement:
    https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

    • For 'google-github-actions/auth@v1' and 'google-github-actions/setup-gcloud@v1', follow example here

Note: turnstyle is not updated:
softprops/turnstyle@v1 is not being maintained since Dec 2020. Most of it functionality is available through the concurrency in Github Actions, but it lacks ability to queue. It either only want latest code deployed or the latest commit.
softprops/turnstyle#43
https://github.com/orgs/community/discussions/5435
TODO:

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhumin8 zhumin8 changed the title chore: replace deprecated command with environment file. chore: replace deprecated github action commands. Jun 6, 2023
@zhumin8 zhumin8 marked this pull request as ready for review June 6, 2023 14:39
@zhumin8 zhumin8 requested a review from a team June 6, 2023 14:39
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup!

@zhumin8 zhumin8 merged commit 1d9cc88 into main Jun 6, 2023
@zhumin8 zhumin8 deleted the replace-deprecated-command-with-environment-file branch June 6, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants