Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Add all common release configuration from alloydb java #1449

Merged
merged 2 commits into from
Sep 1, 2023
Merged

chore(ci): Add all common release configuration from alloydb java #1449

merged 2 commits into from
Sep 1, 2023

Conversation

hessjcg
Copy link
Collaborator

@hessjcg hessjcg commented Aug 31, 2023

This copies the standard AlloyDB build configuration files with minor changes to support
this specific repo.

@hessjcg hessjcg requested a review from a team as a code owner August 31, 2023 18:57
enocom
enocom reviewed Aug 31, 2023
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,10 @@
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to delete this file elsewhere. Let's not add it back here. Customers rarely use it correctly and we end up having to delete it more than anything.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

.github/dependabot.yml Outdated
schedule:
interval: "daily"
# Disable version updates for pip dependencies
open-pull-requests-limit: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing newline

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

.github/sync-repo-settings.yaml Outdated
- "lint"
- "units (8)"
- "units (11)"
# - "graalvm17"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this in the repo here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

.github/workflows/ci.yaml Outdated
env:
JOB_TYPE: clirr

# graalvm17:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This should stay I believe.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the new github workflows for now, including ci.yaml. Otherwise this will be too big a change.
I'll include them as part of #1447

.kokoro/release/snapshot.cfg Outdated
value: "github/cloud-sql-jdbc-socket-factory/.kokoro/release/snapshot.sh"
}
value: "github/alloydb-java-connector/.kokoro/release/snapshot.sh"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

.kokoro/release/snapshot.cfg Outdated
@@ -2,5 +2,5 @@

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/cloud-sql-jdbc-socket-factory/.kokoro/release/snapshot.sh"
}
value: "github/alloydb-java-connector/.kokoro/release/snapshot.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be cloud-sql-jdbc-socket-factory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

.kokoro/release/stage.cfg Outdated
@@ -2,22 +2,18 @@

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/cloud-sql-jdbc-socket-factory/.kokoro/release/stage.sh"
value: "github/alloydb-java-connector/.kokoro/release/stage.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

.kokoro/requirements.in Outdated
wheel
setuptools
typing-extensions
click<8.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

CONTRIBUTING.md
Covenant](http://contributor-covenant.org), version 1.2.0, available at
[http://contributor-covenant.org/version/1/2/0/](http://contributor-covenant.org/version/1/2/0/)

### Running tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a more thoughful merge of CONTRIBUTING.md.

samples/snapshot/pom.xml Outdated
<groupId>com.google.cloud</groupId>
<artifactId>-snapshot</artifactId>
<packaging>jar</packaging>
<name>Google Google Cloud AlloyDB Java Connector Snapshot Samples</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to grep for AlloyDB and alloydb just to get all these

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. (I removed all the samples/ files for now.)

@hessjcg
chore(ci): WIP Adding missing standard build files.
3674842 
chore(ci): WIP Updating existing common standard build files.

chore: Fix remaining alloydb references.

chore(docs): A better merge of CONTRIBUTING.md
@hessjcg hessjcg force-pushed the release-configs-from-alloydb-java branch from 278a013 to 3674842 Compare August 31, 2023 21:14
@hessjcg hessjcg force-pushed the release-configs-from-alloydb-java branch from 764edf8 to 1c578d2 Compare August 31, 2023 21:16
@hessjcg hessjcg requested a review from enocom August 31, 2023 21:17
@hessjcg hessjcg merged commit 5271721 into main Sep 1, 2023
16 of 17 checks passed
@hessjcg hessjcg deleted the release-configs-from-alloydb-java branch September 1, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees

@enocom enocom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hessjcg @enocom