ci: change name of ci environment to 'ci-branch-main' to avoid terraform issues #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
requested changes
Apr 12, 2023
.github/workflows/tests-main.yaml
Outdated
| @@ -69,7 +69,7 @@ jobs: | |||
| name: 'Run E2E Tests' | |||
| run: "./tools/e2e_test_job.sh" | |||
| env: | |||
| ENVIRONMENT_NAME: "ci-main" | |||
| ENVIRONMENT_NAME: "ci-daily" | |||
There was a problem hiding this comment.
This also runs on push events right? We should probably think of a better name that incapsulates periodic and continuous builds because daily isn't fully accurate.
There was a problem hiding this comment.
I have to change the name from 'ci-main' to something else, or else it will break. Google Cloud can't fully delete all the resources with 'ci-main' in the name - some networking components take a day or two to fully disappear.
What about 'ci-branch-main'?
jackwotherspoon
changed the title
jackwotherspoon
approved these changes
Apr 12, 2023
|
Changing name as short-term fix, long-term fix we will want to dynamically change the env name and work will be tracked by #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform has a hard time tearing down and recreating whole environments when they are
too far out of date. Instead, this starts a brand new environment named 'ci-daily'.
I will manually delete the old environment 'ci-main' to free up cloud resources.