Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFE: Add support for Shared VPCs. #2598

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LasseHjorth
Copy link
Contributor

This PR is a continuation of [#2597 2597] - but specific for OFE and this PR is also dependent of this.

The following changes explained:

  • Allow Importing existing VPC to discover shared vpc and subnets.
  • Fixed so page doesn't error out if there is no networks/subnets to import.
  • Import existing VPC with full self_link names as cloud_ids.
  • Moved network config to own blueprint jinja template.
  • Removed private-service-access - this will break creating multiple clusters on the same VPC network, and belongs in community/front-end/ofe/infrastructure_files/vpc_tf/GCP.
  • Modified create filestore filesystem to work with Shared VPCs. (connect mode).
  • Fixed bug in create filestore filesystem, where ghpc was using machine identity and not the identity selected in frontend, to build TF code.
  • Fixed bug in VPCDetailedView where any network would not be displayed if an ongoing cluster config is missing subnet.

Copy link

google-cla bot commented May 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@LasseHjorth LasseHjorth marked this pull request as ready for review May 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants