-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server 2022: Removing BYOL, adding import workflows #1813
base: master
Are you sure you want to change the base?
Conversation
- Removing BYOL workflows as per https://cloud.google.com/compute/docs/instances/windows/ms-licensing-faq#license_mobility_faq -- "If the Windows Server version was released before October 1, 2019, you can, subject to the terms of the licensing agreement, use Windows Server licenses acquired before this date on sole-tenant nodes." Since 2022 was release in 2021, it cannot use BYOL. Adding import workflow for Windows Server 2022, to begin testing.
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bkatyl, LawrenceHwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about exceptions listed in the doc:
"Microsoft makes exceptions for Windows Server licenses that meet the following conditions:
- Acquired under existing enrollments with an effective date before October 1, 2019
- Acquired after October 1, 2019 under Microsoft's Enterprise Agreement True-up (PDF download) ordering process
- Purchased for Windows Server versions released before October 1, 2019"
Are these exceptions only for licenses obtained after Oct 1, 2019, or also for versions of Windows released after that date?
@@ -1,106 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were these two deleted images used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows Server 2022 was released on Aug 18, 2021, so it cannot have been purchased before October 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows Server 2022 BYOL, but since no customer can BYOL the images they need to be removed.
Removing BYOL workflows as per https://cloud.google.com/compute/docs/instances/windows/ms-licensing-faq#license_mobility_faq
Since 2022 was release in 2021, this version of Windows Server cannot use BYOL.
Adding import workflow for Windows Server 2022, to begin testing.
/cc LawrenceHwang