rework conditionals in Set-WindowsUpdateServer #1933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional on line 76 appears to be intended to prevent re-execution after reboot which could cause a reboot loop, but this conditional is also preventing 1st time execution because the test path already exists in a clean install from Windows Server 2019 ISO. Because this test path already exists, registry values based on wu_server_url and wu_server_port are not being set and it is not possible to use a custom server for Windows updates.
In this pull request, the logic has been changed to remove the conditional based on test path existence and instead to set registry values if the new values are different than the current registry. Further the reboot is only performed if registry values are changed.